linux-kernel - Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3841077.a8qRkotiEM@diego>
Date:   Thu, 16 Mar 2017 09:02:47 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     cl@...k-chips.com
Cc:     robh+dt@...nel.org, mark.rutland@....com, zhengxing@...k-chips.com,
        andy.yan@...k-chips.com, jay.xu@...k-chips.com,
        matthias.bgg@...il.com, paweljarosz3691@...il.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
        wsa@...-dreams.de, linux-i2c@...r.kernel.org, jic23@...nel.org,
        knaack.h@....de, lars@...afoo.de, pmeerw@...erw.net,
        wxt@...k-chips.com, david.wu@...k-chips.com,
        linux-iio@...r.kernel.org, shawn.lin@...k-chips.com,
        akpm@...ux-foundation.org, dianders@...omium.org,
        yamada.masahiro@...ionext.com, catalin.marinas@....com,
        will.deacon@....com, afaerber@...e.de, shawnguo@...nel.org,
        khilman@...libre.com, arnd@...db.de, fabio.estevam@....com,
        zhangqing@...k-chips.com, kever.yang@...k-chips.com,
        tony.xie@...k-chips.com, huangtao@...k-chips.com,
        yhx@...k-chips.com, rocky.hao@...k-chips.com
Subject: Re: [PATCH v1 1/7] include: dt-bindings: Add pin function index definition for rockchip pinctrl

Hi,

Am Mittwoch, 15. März 2017, 18:03:51 CET schrieb cl@...k-chips.com:
> From: Chen Liang <cl@...k-chips.com>
> 
> The rk3328 soc need more pin function index for pinctrl.
> 
> Signed-off-by: Chen Liang <cl@...k-chips.com>
> ---
>  include/dt-bindings/pinctrl/rockchip.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/dt-bindings/pinctrl/rockchip.h
> b/include/dt-bindings/pinctrl/rockchip.h index aaec8ba..bc2b6af 100644
> --- a/include/dt-bindings/pinctrl/rockchip.h
> +++ b/include/dt-bindings/pinctrl/rockchip.h
> @@ -63,5 +63,8 @@
>  #define RK_FUNC_2	2
>  #define RK_FUNC_3	3
>  #define RK_FUNC_4	4
> +#define RK_FUNC_5	5
> +#define RK_FUNC_6	6
> +#define RK_FUNC_7	7

please don't amend that function list anymore.

Only RK_FUNC_GPIO serves a real purpose but having constants FUNC_7 mapping 
simply to 7 does not help understand things better, so it's way easier to just 
have "7" as function in pinctrl entries in the devicetree.

That list is mainly a remnant to keep compatibility with old devicetrees and I 
guess I should add a deprecated notice at some point :-) .


Heiko