linux-kernel - Re: [RFC PATCH] rework memory hotplug onlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170316085404.GE30501@dhcp22.suse.cz>
Date:   Thu, 16 Mar 2017 09:54:04 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     "Kani, Toshimitsu" <toshi.kani@....com>
Cc:     "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "zhenzhang.zhang@...wei.com" <zhenzhang.zhang@...wei.com>,
        "tangchen@...fujitsu.com" <tangchen@...fujitsu.com>,
        "arbab@...ux.vnet.ibm.com" <arbab@...ux.vnet.ibm.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "daniel.kiper@...cle.com" <daniel.kiper@...cle.com>,
        "xieyisheng1@...wei.com" <xieyisheng1@...wei.com>,
        "iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
        "qiuxishi@...wei.com" <qiuxishi@...wei.com>,
        "yasu.isimatu@...il.com" <yasu.isimatu@...il.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "imammedo@...hat.com" <imammedo@...hat.com>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "slaoub@...il.com" <slaoub@...il.com>
Subject: Re: [RFC PATCH] rework memory hotplug onlining

On Wed 15-03-17 23:08:14, Kani, Toshimitsu wrote:
> On Wed, 2017-03-15 at 10:13 +0100, Michal Hocko wrote:
>  :
> > @@ -388,39 +389,44 @@ static ssize_t show_valid_zones(struct device
> > *dev,
> >  				struct device_attribute *attr, char
> > *buf)
> >  {
> >  	struct memory_block *mem = to_memory_block(dev);
> > -	unsigned long start_pfn, end_pfn;
> > -	unsigned long valid_start, valid_end, valid_pages;
> > -	unsigned long nr_pages = PAGES_PER_SECTION *
> > sections_per_block;
> > +	unsigned long start_pfn, nr_pages;
> > +	bool append = false;
> >  	struct zone *zone;
> > -	int zone_shift = 0;
> > +	int nid;
> >  
> >  	start_pfn = section_nr_to_pfn(mem->start_section_nr);
> > -	end_pfn = start_pfn + nr_pages;
> > +	zone = page_zone(pfn_to_page(start_pfn));
> > +	nr_pages = PAGES_PER_SECTION * sections_per_block;
> >  
> > -	/* The block contains more than one zone can not be
> > offlined. */
> > -	if (!test_pages_in_a_zone(start_pfn, end_pfn, &valid_start,
> > &valid_end))
> > +	/*
> > +	 * The block contains more than one zone can not be
> > offlined.
> > +	 * This can happen e.g. for ZONE_DMA and ZONE_DMA32
> > +	 */
> > +	if (!test_pages_in_a_zone(start_pfn, start_pfn + nr_pages,
> > NULL, NULL))
> >  		return sprintf(buf, "none\n");
> >  
> > -	zone = page_zone(pfn_to_page(valid_start));
> 
> Please do not remove the fix made in a96dfddbcc043. zone needs to be
> set from valid_start, not from start_pfn.

Thanks for pointing this out. I was scratching my head about this part
but was too tired from previous git archeology so I didn't check the
history of this particular part.

I will restore the original behavior but before I do that I am really
curious whether partial memblocks are even supported for onlining. Maybe
I am missing something but I do not see any explicit checks for NULL
struct page when we set zone boundaries or online a memblock. Is it
possible those memblocks are just never hotplugable?
-- 
Michal Hocko
SUSE Labs