linux-kernel - Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3+dk1XMeefWPDKsQOmYC=Tz5zkzQ8d2tZcc90QczSMxw@mail.gmail.com>
Date:   Thu, 16 Mar 2017 11:05:35 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     linux-pcmcia@...ts.infradead.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        oss@...error.net, linuxppc-dev@...abs.org,
        Claudiu Manoil <claudiu.manoil@....com>, qiang.zhao@....com
Subject: Re: [PATCH] drivers/pcmcia: NO_IRQ removal for electra_cf.c

On Thu, Mar 16, 2017 at 10:55 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
> Arnd Bergmann <arnd@...db.de> writes:
>> On Wed, Mar 15, 2017 at 6:35 AM, Michael Ellerman <mpe@...erman.id.au> wrote:
>>> I'll do patches for everything above that's not drivers/soc or
>>> include/soc and hopefully we can hear from someone at NXP on the plans
>>> for getting the soc parts enabled on arm.
>>
>> I think the removal of the NO_IRQ references is a requirement for
>> getting the drivers working properly on ARM, as the OF platform
>> code will use '0' for invalid IRQs.
>
> OK. So the #define NO_IRQ (-1) in arch/arm/include/asm/irq.h is a red
> herring and should be ignored for anything modern?

Correct. There are a couple of older (non-DT) platforms that still rely on it,
and I also have patches for those, which I intend to revisit at some point.

     Arnd