| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CADnq5_PBOkkMB_c4eR-wg6a3bGHzSfeM1sr1UMpz_jsVoHtyog@mail.gmail.com>
Date: Wed, 15 Mar 2017 22:07:37 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: David Binderman <dcb314@...mail.com>
Cc: "alexander.deucher@....com" <alexander.deucher@....com>,
"christian.koenig@....com" <christian.koenig@....com>,
"airlied@...ux.ie" <airlied@...ux.ie>,
"amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs
On Mon, Mar 6, 2017 at 4:40 AM, David Binderman <dcb314@...mail.com> wrote:
>
> Hello there,
> 1
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1041] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1037]: (style) Same expression on both sides of '|'.
>
> Maybe the macro AMD_CG_SUPPORT_GFX_MGLS is used twice ?
>
> 2.
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1070] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1066]: (style) Same expression on both sides of '|'.
>
> Duplicate.
>
> In the same file:
>
> linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:792]: (style) Variable 'r' is assigned a value that is never used.
>
> Source code is
>
> r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
>
> return 0;
Thanks, patches sent.
Alex
>
> Regards
>
> David Binderman
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Powered by blists - more mailing lists