linux-kernel - Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 14:09:46 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     lgirdwood@...il.com, bardliao@...ltek.com, oder_chiou@...ltek.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell
 XPS 9343 I2S mode

On Thu, Mar 16, 2017 at 04:39:51PM +0800, Kai-Heng Feng wrote:

> +	switch (event) {
> +	case SND_SOC_DAPM_PRE_PMD:
> +	case SND_SOC_DAPM_POST_PMD:
> +	case SND_SOC_DAPM_POST_PMU:
> +		snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE);
> +		break;
> +	case SND_SOC_DAPM_PRE_PMU:
> +		snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_UNMUTE);
> +		break;

After power up we mute the amplifier?  That's worthy of a comment...

> +	rt286->is_dell_dino = dmi_check_system(dmi_dell_dino) ? true : false;
> +

Just directly assign the boolean value, the ternery operator is just
making thins harder to read here.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)