linux-kernel - Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170316022218.GE14380@two.firstfloor.org>
Date:   Wed, 15 Mar 2017 19:22:18 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     acme@...nel.org, mingo@...nel.org, jolsa@...nel.org,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] perf, tools, script: Add brstackinsn for branch stacks

> > +	memset(&al, 0, sizeof(al));
> > +	if (end - start > MAXBB - MAXINSN) {
> > +		if (last)
> > +			printf("\tbrstack does not reach to final jump (%" PRIx64 "-%" PRIx64 ")\n",
> > +					start, end);
> > +		else
> > +			printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n",

Thanks. Should be %" PRIu64 " of course.

Arnaldo, can you do the change or should I send a patch?

-Andi

> > +					start, end, end - start);
> 
> This looks to be breaking the build on ppc64:
> 
>   builtin-script.c: In function ‘grab_bb’:
>   builtin-script.c:595:11: error: format ‘%ld’ expects argument of type ‘long int’, but argument 4 has type ‘u64 {aka long long unsigned int}’ [-Werror=format=]
>       printf("\tblock %" PRIx64 "-%" PRIx64 " (%ld) too long to dump\n", start, end, end - start);
>              ^
> 
> cheers
>