linux-kernel - Re: [PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 15:54:58 +0100
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Sean Paul <seanpaul@...omium.org>,
        linux-rockchip@...ts.infradead.org, dri-devel@...ts.freedesktop.org
Cc:     zain wang <wzz@...k-chips.com>, Lin Huang <hl@...k-chips.com>,
        Tomeu Vizoso <tomeu.vizoso@...labora.com>,
        Douglas Anderson <dianders@...omium.org>,
        linux-kernel@...r.kernel.org, Yakir Yang <ykk@...k-chips.com>,
        Tomasz Figa <tomasz.figa@...omium.com>,
        Stéphane Marchesin <marcheu@...omium.org>
Subject: Re: [PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when
 powering up edp phy

On 10.03.2017 05:32, Sean Paul wrote:
> From: zain wang <wzz@...k-chips.com>
>
> Following the correct power up sequence:
> dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00

Please fix the message.

>
> Cc: Stéphane Marchesin <marcheu@...omium.org>
> Signed-off-by: zain wang <wzz@...k-chips.com>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 10 ++++++++--
>  drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h |  3 +++
>  2 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> index b47c5af43560..bb72f8b0e603 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
> @@ -321,10 +321,16 @@ void analogix_dp_set_analog_power_down(struct analogix_dp_device *dp,
>  		break;
>  	case POWER_ALL:
>  		if (enable) {
> -			reg = DP_PHY_PD | AUX_PD | CH3_PD | CH2_PD |
> -				CH1_PD | CH0_PD;
> +			reg = DP_ALL_PD;
>  			writel(reg, dp->reg_base + phy_pd_addr);
>  		} else {
> +			reg = DP_ALL_PD;
> +			writel(reg, dp->reg_base + phy_pd_addr);
Do we need it? register should be already at proper state, shouldn't be?
> +			usleep_range(10, 15);
> +			reg &= ~DP_INC_BG;
> +			writel(reg, dp->reg_base + phy_pd_addr);
> +			usleep_range(10, 15);
> +
>  			writel(0x00, dp->reg_base + phy_pd_addr);
>  		}
>  		break;
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h
> index 40200c652533..9602668669f4 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.h
> @@ -342,12 +342,15 @@
>  #define DP_PLL_REF_BIT_1_2500V			(0x7 << 0)
>  
>  /* ANALOGIX_DP_PHY_PD */
> +#define DP_INC_BG				(0x1 << 7)
> +#define DP_EXP_BG				(0x1 << 6)
>  #define DP_PHY_PD				(0x1 << 5)
>  #define AUX_PD					(0x1 << 4)
>  #define CH3_PD					(0x1 << 3)
>  #define CH2_PD					(0x1 << 2)
>  #define CH1_PD					(0x1 << 1)
>  #define CH0_PD					(0x1 << 0)
> +#define DP_ALL_PD				(0xff)
>  
>  /* ANALOGIX_DP_PHY_TEST */
>  #define MACRO_RST				(0x1 << 5)