linux-kernel - Re: [PATCH V4] dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw bridges (LVDS-DP++)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170316023457.GU3618@dragon>
Date:   Thu, 16 Mar 2017 10:34:59 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Peter Senna Tschudin <peter.senna@...labora.com>
Cc:     airlied@...ux.ie, architt@...eaurora.org,
        akpm@...ux-foundation.org, daniel.vetter@...ll.ch,
        davem@...emloft.net, devicetree@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, enric.balletbo@...labora.com,
        eballetbo@...il.com, galak@...eaurora.org,
        gregkh@...uxfoundation.org, heiko@...ech.de,
        ijc+devicetree@...lion.org.uk, javier@...hile0.org, jslaby@...e.cz,
        kernel@...gutronix.de, linux-arm-kernel@...ts.infradead.org,
        linux@...linux.org.uk, linux-kernel@...r.kernel.org,
        linux@...ck-us.net, mark.rutland@....com, martin.donnelly@...com,
        martyn.welch@...labora.co.uk, mchehab@....samsung.com,
        pawel.moll@....com, peter.senna@...il.com, p.zabel@...gutronix.de,
        thierry.reding@...il.com, rmk+kernel@...linux.org.uk,
        robh+dt@...nel.org, tiwai@...e.com, treding@...dia.com,
        laurent.pinchart@...asonboard.com, Rob Herring <robh@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>
Subject: Re: [PATCH V4] dts/imx6q-b850v3: Use megachips-stdpxxxx-ge-b850v3-fw
 bridges (LVDS-DP++)

On Tue, Mar 14, 2017 at 10:23:02AM +0100, Peter Senna Tschudin wrote:
> Configures the megachips-stdpxxxx-ge-b850v3-fw bridges on the GE
> B850v3 dts file.
> 
> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Cc: Martyn Welch <martyn.welch@...labora.co.uk>
> Cc: Martin Donnelly <martin.donnelly@...com>
> Cc: Javier Martinez Canillas <javier@...hile0.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Fabio Estevam <fabio.estevam@....com>
> Signed-off-by: Peter Senna Tschudin <peter.senna@...labora.com>

To match i.MX patch style, the subject prefix should be something like
'ARM: dts: imx6q-b850v3: ...'.

> ---
> Subject was [PATCH V4 4/4] ...
> But patches 1, 2, and 3 are already upstream and were not resent.
> 
> Changes from V3:
>  - Newline fixes
>  - Removed 'status = "okay";' from '&mux2_i2c2'
>  - Sorted device nodes in order of unit address
> 
> Unchanged since V1.
>  arch/arm/boot/dts/imx6q-b850v3.dts | 66 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6q-b850v3.dts b/arch/arm/boot/dts/imx6q-b850v3.dts
> index d78514c..ef67b47 100644
> --- a/arch/arm/boot/dts/imx6q-b850v3.dts
> +++ b/arch/arm/boot/dts/imx6q-b850v3.dts
> @@ -72,6 +72,14 @@
>  		fsl,data-mapping = "spwg";
>  		fsl,data-width = <24>;
>  		status = "okay";
> +
> +		port@4 {
> +			reg = <4>;
> +

Great, it's been fixed.

> +			lvds0_out: endpoint {
> +				remote-endpoint = <&stdp4028_in>;
> +			};
> +		};
>  	};
>  };
>  
> @@ -142,3 +150,61 @@
>  		reg = <0x4a>;
>  	};
>  };
> +
> +&mux2_i2c2 {
> +	clock-frequency = <100000>;
> +
> +	stdp2690@72 {
> +		compatible = "megachips,stdp2690-ge-b850v3-fw";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x72>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;

But this one ...

> +				stdp2690_in: endpoint {
> +					remote-endpoint = <&stdp4028_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;

... here ...

> +				stdp2690_out: endpoint {
> +					/* Connector for external display */
> +				};
> +			};
> +		};
> +	};
> +
> +	stdp4028@73 {
> +		compatible = "megachips,stdp4028-ge-b850v3-fw";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x73>;
> +		interrupt-parent = <&gpio2>;
> +		interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;

... here ...

> +				stdp4028_in: endpoint {
> +					remote-endpoint = <&lvds0_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;

... and here.

I fixed up all of them and applied patch.

Shawn

> +				stdp4028_out: endpoint {
> +					remote-endpoint = <&stdp2690_in>;
> +				};
> +			};
> +		};
> +	};
> +};
> -- 
> 2.9.3
>