linux-kernel - Re: [PATCH 1/1] pinctrl: st: add irq_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e80366b0-a044-0908-13bd-49856827a407@st.com>
Date:   Thu, 16 Mar 2017 15:39:19 +0000
From:   Patrice CHOTARD <patrice.chotard@...com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Peter Griffin <peter.griffin@...aro.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 1/1] pinctrl: st: add irq_request_resources callback



On 03/14/2017 03:05 PM, Linus Walleij wrote:
> On Mon, Feb 27, 2017 at 2:49 PM,  <patrice.chotard@...com> wrote:
>
>> From: Patrice Chotard <patrice.chotard@...com>
>>
>> When using GPIO as IRQ source, the GPIO must be configured
>> in INPUT. The callback dedicated for this was missing in
>> pinctrl-st driver.
>>
>> This fix the following kernel error when trying to lock a gpio
>> as IRQ:
>>
>> [    7.521095] gpio gpiochip7: (PIO11): gpiochip_lock_as_irq: tried to flag a GPIO set as output for IRQ
>> [    7.526018] gpio gpiochip7: (PIO11): unable to lock HW IRQ 6 for IRQ
>> [    7.529405] genirq: Failed to request resources for 0-0053 (irq 81) on irqchip GPIO
>>
>> Signed-off-by: Patrice Chotard <patrice.chotard@...com>
>
> I see what problem you are trying to solve.
>
>> +static int st_gpio_irq_request_resources(struct irq_data *d)
>> +{
>> +       struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
>> +       int pin = d->hwirq;
>> +
>> +       return st_gpio_direction_input(gc, pin);
>> +}
> (...)
>> +       .irq_request_resources  = st_gpio_irq_request_resources,
>
> But this is just hiding the problem I'm afraid.
>

Hi Linus

> Now thay you override .irq_request_resources()
> gpiochip_irq_reqres() will not be called, so then you have
> to lock the irq in the driver, with something like:
>
> ret = gpiochip_lock_as_irq(&chip->gc, d->hwirq);
>         if (ret)
>                 goto out;
>

Ah yes, i didn't noticed that point, thanks for the tips.

> You also have to implement the .irq_release_resources()
> callback and unlock the IRQ there.

In this case, yes the release becomes mandatory.

I will send a v2.

Thanks

Patrice

>
> Yours,
> Linus Walleij
>