linux-kernel - Re: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328 evaluation board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <63969127-3fcd-658c-2986-8ded6d93c433@arm.com>
Date:   Thu, 16 Mar 2017 16:18:40 +0000
From:   Andre Przywara <andre.przywara@....com>
To:     cl@...k-chips.com, heiko@...ech.de
Cc:     mark.rutland@....com, wsa@...-dreams.de, linux-iio@...r.kernel.org,
        catalin.marinas@....com, shawn.lin@...k-chips.com,
        will.deacon@....com, kever.yang@...k-chips.com,
        dianders@...omium.org, yamada.masahiro@...ionext.com,
        tony.xie@...k-chips.com, linux-i2c@...r.kernel.org,
        pmeerw@...erw.net, lars@...afoo.de, zhengxing@...k-chips.com,
        khilman@...libre.com, linux-rockchip@...ts.infradead.org,
        jay.xu@...k-chips.com, wxt@...k-chips.com, huangtao@...k-chips.com,
        devicetree@...r.kernel.org, zhangqing@...k-chips.com,
        paweljarosz3691@...il.com, arnd@...db.de, yhx@...k-chips.com,
        knaack.h@....de, robh+dt@...nel.org, matthias.bgg@...il.com,
        rocky.hao@...k-chips.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, david.wu@...k-chips.com,
        fabio.estevam@....com, andy.yan@...k-chips.com,
        akpm@...ux-foundation.org, shawnguo@...nel.org, afaerber@...e.de,
        jic23@...nel.org
Subject: Re: [PATCH v1 6/7] arm64: dts: rockchip: add dts file for RK3328
 evaluation board

Hi Chen,

On 16/03/17 01:45, cl@...k-chips.com wrote:
> From: Chen Liang <cl@...k-chips.com>
> 
> This patch add rk3328-evb.dts for RK3328 evaluation board.
> Tested on RK3328 evb.
> 
> Signed-off-by: Chen Liang <cl@...k-chips.com>
> ---
>  arch/arm64/boot/dts/rockchip/Makefile       |  1 +
>  arch/arm64/boot/dts/rockchip/rk3328-evb.dts | 57 +++++++++++++++++++++++++++++
>  2 files changed, 58 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> 
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 3a86289..853fc7d 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-orion-r68-meta.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-px5-evb.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3368-r88.dtb
>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-evb.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3328-evb.dtb
>  
>  always		:= $(dtb-y)
>  subdir-y	:= $(dts-dirs)
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-evb.dts b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> new file mode 100644
> index 0000000..cf27239
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-evb.dts
> @@ -0,0 +1,57 @@
> +/*
> + * Copyright (c) 2017 Fuzhou Rockchip Electronics Co., Ltd
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This library is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This library is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +/dts-v1/;
> +#include "rk3328.dtsi"
> +
> +/ {
> +	model = "Rockchip RK3328 EVB";
> +	compatible = "rockchip,rk3328-evb", "rockchip,rk3328";
> +
> +	chosen {
> +		stdout-path = "serial2:1500000n8";

Is that really 1.5MBit/s?

> +	};
> +};
> +
> +&uart2 {
> +	status = "okay";
> +};

I don't have the board, but would expect to see more peripherals
mentioned in the .dtsi enabled here.
For sure the board has an (micro)SD card slot, possibly even Ethernet?

Cheers,
Andre.