linux-kernel - Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJYdmeNc48=OOvRiUjqPBJhz9RCbzeaRGu1Tfm=hrvzkJrSsag@mail.gmail.com>
Date:   Thu, 16 Mar 2017 09:39:44 -0700
From:   Moritz Fischer <moritz.fischer.private@...il.com>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Julia Cartwright <julia@...com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Devicetree List <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] ARM: zynq: Add #io-channel-cells to (x)adc node for iio-hwmon

On Thu, Mar 16, 2017 at 9:16 AM, Michal Simek <michal.simek@...inx.com> wrote:
> Hi,
>
> On 8.3.2017 21:11, Moritz Fischer wrote:
>> Fix
>>
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@...07100
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@...07100
>> OF: /iio_hwmon: could not get #io-channel-cells for
>> /amba/adc@...07100
>>
>> by adding the #io-channel-cells property.
>>
>> Signed-off-by: Moritz Fischer <mdf@...nel.org>
>> Cc: Michal Simek <michal.simek@...inx.com>
>> Cc: Sören Brinkmann <soren.brinkmann@...inx.com>
>> Cc: Julia Cartwright <julia@...com>
>> Cc: linux-kernel@...r.kernel.org
>> Cc: devicetree@...r.kernel.org
>> ---
>>
>> Changes from v1:
>> - fix messed up commit message
>> ---
>>  arch/arm/boot/dts/zynq-7000.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index f3ac9bf..98233a8 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -72,6 +72,7 @@
>>                       interrupts = <0 7 4>;
>>                       interrupt-parent = <&intc>;
>>                       clocks = <&clkc 12>;
>> +                     #io-channel-cells = <1>;
>>               };
>>
>>               can0: can@...08000 {
>>
>
> I think it will be good to the next step too.
> It means also add iio-hwmon node too.
>
> What do you think?

I hadn't put it in there since dts is supposed to describe hw,
but obviously putting the actual hwmon in there makes it more useful.

I can resubmit with the hwmon node in there.

Cheers,
Moritz