linux-kernel - Re: [RFC PATCH] rework memory hotplug onlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 18:40:51 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     "Kani, Toshimitsu" <toshi.kani@....com>
Cc:     "zhenzhang.zhang@...wei.com" <zhenzhang.zhang@...wei.com>,
        "tangchen@...fujitsu.com" <tangchen@...fujitsu.com>,
        "arbab@...ux.vnet.ibm.com" <arbab@...ux.vnet.ibm.com>,
        "vkuznets@...hat.com" <vkuznets@...hat.com>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "daniel.kiper@...cle.com" <daniel.kiper@...cle.com>,
        "xieyisheng1@...wei.com" <xieyisheng1@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "iamjoonsoo.kim@....com" <iamjoonsoo.kim@....com>,
        "qiuxishi@...wei.com" <qiuxishi@...wei.com>,
        "yasu.isimatu@...il.com" <yasu.isimatu@...il.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "aarcange@...hat.com" <aarcange@...hat.com>,
        "vbabka@...e.cz" <vbabka@...e.cz>,
        "imammedo@...hat.com" <imammedo@...hat.com>,
        "rientjes@...gle.com" <rientjes@...gle.com>,
        "mgorman@...e.de" <mgorman@...e.de>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "slaoub@...il.com" <slaoub@...il.com>
Subject: Re: [RFC PATCH] rework memory hotplug onlining

On Thu 16-03-17 17:19:34, Kani, Toshimitsu wrote:
> On Thu, 2017-03-16 at 09:54 +0100, Michal Hocko wrote:
> > On Wed 15-03-17 23:08:14, Kani, Toshimitsu wrote:
> > > On Wed, 2017-03-15 at 10:13 +0100, Michal Hocko wrote:
>  :
> > > > -	zone = page_zone(pfn_to_page(valid_start));
> > > 
> > > Please do not remove the fix made in a96dfddbcc043. zone needs to
> > > be set from valid_start, not from start_pfn.
> > 
> > Thanks for pointing this out. I was scratching my head about this
> > part but was too tired from previous git archeology so I didn't check
> > the history of this particular part.
> >
> > I will restore the original behavior but before I do that I am really
> > curious whether partial memblocks are even supported for onlining.
> > Maybe I am missing something but I do not see any explicit checks for
> > NULL struct page when we set zone boundaries or online a memblock. Is
> > it possible those memblocks are just never hotplugable?
> 
> check_hotplug_memory_range() checks if a given range is aligned by the
> section size.

Ohh, right you are! I have completely missed check_hotplug_memory_range.
Thanks for pointing it out.

-- 
Michal Hocko
SUSE Labs