linux-kernel - Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALZtONAjUCLceJMGQ5OD+vT3CqzywgU2JC5L2KWhJpA3nxng7w@mail.gmail.com>
Date:   Thu, 16 Mar 2017 14:20:56 -0400
From:   Dan Streetman <ddstreet@...e.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Mahipal Reddy <mahipalreddy2006@...il.com>,
        Mahipal Challa <Mahipal.Challa@...ium.com>,
        Seth Jennings <sjenning@...hat.com>,
        Linux-MM <linux-mm@...ck.org>,
        linux-kernel <linux-kernel@...r.kernel.org>, pathreya@...ium.com,
        Vishnu Nair <Vishnu.Nair@...ium.com>
Subject: Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu
<herbert@...dor.apana.org.au> wrote:
> On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote:
>>
>>
>> setting the ASYNC bit makes it synchronous?  that seems backwards...?
>
> You set the ASYNC bit in the mask and leave it clear in the type.
> That way only algorithms with the ASYNC bit off will match.

aha, ok i get it now.

>> zswap gets the fun of being the first crypto compression consumer to
>> switch to the new api? ;-)
>
> BTW I think we should hold off on converting zswap for now.

ok that sounds good, we can wait.  Thanks!