linux-kernel - Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel entry to OF device ID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Mar 2017 15:38:19 -0300
From:   Javier Martinez Canillas <javier@....samsung.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        James Hogan <james.hogan@...tec.com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Paul Burton <paul.burton@...tec.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [RESEND PATCH 1/2] auxdisplay: img-ascii-lcd: Add a sentinel
 entry to OF device ID table

Hello Dmitry,

On 03/16/2017 03:25 PM, Dmitry Torokhov wrote:
> On Fri, Mar 10, 2017 at 10:22 AM, Dmitry Torokhov
> <dmitry.torokhov@...il.com> wrote:
>>
>> On Fri, Mar 10, 2017 at 10:33:06AM -0300, Javier Martinez Canillas wrote:
>>> The OF device ID table doesn't have a sentinel NULL entry and so it
>>> causes the following error:
>>>
>>> FATAL: drivers/auxdisplay/img-ascii-lcd: struct of_device_id is not terminated with a NULL entry!
>>> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
>>> make[1]: *** [__modpost] Error 1
>>> Makefile:1493: recipe for target 'modules' failed
>>> make: *** [modules] Error 2
>>>
>>> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>>
>> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>
>> This was also causing issues with 0-day builder when driver is built
>> into the kernel.
> 
> It looks like Greg KH picked my version of this patch...
>

Great, glad that your version was picked since it seems these two patches
were never going to make it.
 
> Thanks.
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America