linux-kernel - Re: [PATCH 00/13] Add HD44780 Character LCD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX6stteo3VPk49+3rYU8pOKOhPWmG2ckdQ4wj9PzLR1bA@mail.gmail.com>
Date:   Fri, 17 Mar 2017 08:40:38 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Willy Tarreau <willy@...roxy.com>,
        Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/13] Add HD44780 Character LCD support

Hi Linus,

On Thu, Mar 16, 2017 at 9:50 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Mon, Feb 6, 2017 at 3:38 PM, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
>> Note that Linux has other support for HD44780 Character LCDs, but none of
>> it is generic:
>>   - drivers/misc/arm-charlcd.c involves a custom IP block for interfacing
>>     to the LCD controller,
>
> I can move this over to the generic framework if I get some example
> of what needs to be done. At the very least the file should be moved
> over to auxdisplay.

Should be as simple as setting up the ops:

        static const struct charlcd_ops arm_charlcd_ops = {
                .write_cmd      = charlcd_4bit_command,
               .write_cmd_raw4 = wrapper around writel(x,
lcd->virtbase + CHAR_COM),
               .write_data     = charlcd_4bit_char,
        };

and replacing the custom initialization with:

        lcd = charlcd_alloc(sizeof(size(struct arm_charlcd));
        ...
        lcd->ifwidth = 4;
        lcd->width = FIXME;
        lcd->height = 2;
        cd->ops = &arm_charlcd_ops;
        charlcd_register(lcd);

There's no suspend/resume support in the charlcd core yet, though.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds