linux-kernel - Re: Does braille console work?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170317005355.xwym3zpamym3rwp6@var.youpi.perso.aquilenet.fr>
Date:   Fri, 17 Mar 2017 01:53:55 +0100
From:   Samuel Thibault <samuel.thibault@...-lyon.org>
To:     Aleksey Makarov <aleksey.makarov@...aro.org>
Cc:     linux-serial@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org
Subject: Re: Does braille console work?

Hello,

Aleksey Makarov, on jeu. 16 mars 2017 17:02:53 +0300, wrote:
> There can be 3 outcomes from this function:
> 1) it returns NULL and does not set brl_options
> 2) it returns NULL and set the variable pointed by str to NULL
> 3) it returns non-NULL

Uh, that's odd indeed, the intent was that it'd return an error code
only.

> To register a braille console (i. e. to call __add_preferred_console()
> with non-NULL brl_options) function _braille_console_setup() should
> return NULL and initialize brl_options. 

return 0 (as in no error), actually, in the intent.

> 1) in this case brl_options is NULL and non-braille console is registered
> 2) kernel produces oops later in console_setup().  I reproduced it
>    passing "console=brl=aaa" parameter to kernel, see below.
> 3) no console is registered
> 
> So braille console registration should not work.  What do I miss?

Nothing, the code transformation was broken :/

> So it looks like braille console has not been used for more than 3 years.
> Should we remote it?

Please, no :)

It is indeed not often useful, since one would usually use a userland
daemon to access the system, but when one's system does not boot
properly or something similar, it's useful to have the braille
console. That's just very not often useful.

Samuel