linux-kernel - Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell XPS 9343 I2S mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20170317130444.jw5ahc2hmgdoacpk@sirena.org.uk>
Date:   Fri, 17 Mar 2017 13:04:44 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     lgirdwood@...il.com, bardliao@...ltek.com, oder_chiou@...ltek.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ASoC: rt286: fix headphone click/crack noise on Dell
 XPS 9343 I2S mode

On Fri, Mar 17, 2017 at 02:41:04AM +0000, Kai-Heng Feng wrote:
> On Thu, Mar 16, 2017 at 10:09 PM Mark Brown <broonie@...nel.org> wrote:

> > > +     rt286->is_dell_dino = dmi_check_system(dmi_dell_dino) ? true :
> > false;

> > Just directly assign the boolean value, the ternery operator is just
> > making thins harder to read here.

> Should I make the int implicitly convert to bool or use '!!' operator?

Use implicit conversion like you're already doing - the above already
evaluates the function as a boolean in order to use it in the ternery
operator.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)