linux-kernel - Re: [PATCH] drm/amdgpu: remove redundant outer loop and remove commented out code

Open Source and information security mailing list archives

Message-ID: <CADnq5_P8712br5qGWg1FQpy8toQwptgDoG2D66BLhTqESNPggA@mail.gmail.com>
Date:   Fri, 17 Mar 2017 14:39:11 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>, Rex Zhu <Rex.Zhu@....com>,
        Tom St Denis <tom.stdenis@....com>, jimqu <Jim.Qu@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu: remove redundant outer loop and remove
 commented out code

On Fri, Mar 17, 2017 at 10:37 AM, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The outer loop is redundant and can be removed as it is doing nothing
> useful. Also remove some commented out code that is not being used.
>
> Detected by CoverityScan, CID#1402073
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied.  thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 27 +++++++--------------------
>  1 file changed, 7 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
> index 9ea99348e493..72dea663f113 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c
> @@ -273,24 +273,14 @@ static int vce_v2_0_start(struct amdgpu_device *adev)
>
>  static int vce_v2_0_stop(struct amdgpu_device *adev)
>  {
> -       int i, j;
> +       int i;
>         int status;
>
>         if (vce_v2_0_lmi_clean(adev)) {
>                 DRM_INFO("vce is not idle \n");
>                 return 0;
>         }
> -/*
> -       for (i = 0; i < 10; ++i) {
> -               for (j = 0; j < 100; ++j) {
> -                       status = RREG32(mmVCE_FW_REG_STATUS);
> -                       if (!(status & 1))
> -                               break;
> -                       mdelay(1);
> -               }
> -               break;
> -       }
> -*/
> +
>         if (vce_v2_0_wait_for_idle(adev)) {
>                 DRM_INFO("VCE is busy, Can't set clock gateing");
>                 return 0;
> @@ -299,14 +289,11 @@ static int vce_v2_0_stop(struct amdgpu_device *adev)
>         /* Stall UMC and register bus before resetting VCPU */
>         WREG32_P(mmVCE_LMI_CTRL2, 1 << 8, ~(1 << 8));
>
> -       for (i = 0; i < 10; ++i) {
> -               for (j = 0; j < 100; ++j) {
> -                       status = RREG32(mmVCE_LMI_STATUS);
> -                       if (status & 0x240)
> -                               break;
> -                       mdelay(1);
> -               }
> -               break;
> +       for (i = 0; i < 100; ++i) {
> +               status = RREG32(mmVCE_LMI_STATUS);
> +               if (status & 0x240)
> +                       break;
> +               mdelay(1);
>         }
>
>         WREG32_P(mmVCE_VCPU_CNTL, 0, ~0x80001);
> --
> 2.11.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives