linux-kernel - Re: [PATCH v21 03/13] clocksource: arm_arch_timer: remove arch_timer_detect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 17 Mar 2017 18:07:26 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     fu.wei@...aro.org
Cc:     rjw@...ysocki.net, lenb@...nel.org, daniel.lezcano@...aro.org,
        tglx@...utronix.de, marc.zyngier@....com,
        lorenzo.pieralisi@....com, sudeep.holla@....com,
        hanjun.guo@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linaro-acpi@...ts.linaro.org, linux-kernel@...r.kernel.org,
        linux-acpi@...r.kernel.org, rruigrok@...eaurora.org,
        harba@...eaurora.org, cov@...eaurora.org, timur@...eaurora.org,
        graeme.gregory@...aro.org, al.stone@...aro.org, jcm@...hat.com,
        wei@...hat.com, arnd@...db.de, catalin.marinas@....com,
        will.deacon@....com, Suravee.Suthikulpanit@....com,
        leo.duran@....com, wim@...ana.be, linux@...ck-us.net,
        linux-watchdog@...r.kernel.org, tn@...ihalf.com,
        christoffer.dall@...aro.org, julien.grall@....com
Subject: Re: [PATCH v21 03/13] clocksource: arm_arch_timer: remove
 arch_timer_detect_rate

On Tue, Feb 07, 2017 at 02:50:05AM +0800, fu.wei@...aro.org wrote:
> From: Fu Wei <fu.wei@...aro.org>
> 
> The original counter frequency detection call(arch_timer_detect_rate)
> include getting the frequency from the per-cpu arch-timer and the
> memory-mapped (MMIO) timer interfaces. But they will be needed only when
> the system initializes the relevant timer.
> 
> This patch remove arch_timer_detect_rate founction, and use the
> arch_timer_get_sysreg_freq and arch_timer_get_mmio_freq directly.
> 
> Signed-off-by: Fu Wei <fu.wei@...aro.org>

Could you please fold this with the prior patch?

> @@ -1087,7 +1072,12 @@ static int __init arch_timer_mem_init(struct device_node *np)
>  	 */
>  	if (!arch_timer_rate &&
>  	    of_property_read_u32(np, "clock-frequency", &arch_timer_rate))
> -		arch_timer_detect_rate(base);
> +		arch_timer_rate = arch_timer_get_mmio_freq(base);
> +	if (!arch_timer_rate) {
> +		pr_err(FW_BUG "frequency not available for MMIO timer.\n");

It would be better to say "MMIO frequency not available.\n" here.

Thanks,
Mark.