linux-kernel - Re: [PATCH] pci: quirk cavium: Add device ID range check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170317162755.60423972@t450s.home>
Date:   Fri, 17 Mar 2017 16:27:55 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Manish Jaggi <mjaggi@...iumnetworks.com>
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Daney, David" <David.Daney@...ium.com>, bhelgaas@...gle.com
Subject: Re: [PATCH] pci: quirk cavium: Add device ID range check

On Fri, 17 Mar 2017 12:46:29 +0530
Manish Jaggi <mjaggi@...iumnetworks.com> wrote:

>   ACS quirk applies to devices with ID in the range a000-a0XX.
>   The patch adds a check.This matches on-chip pci devices for
>   CN81xx/CN83xx/CN88xx
> 
>   This patch adds check to
>   b404bcfbf0 : PCI: Add ACS quirk for all Cavium devices
> 
> Signed-off-by: Manish Jaggi <mjaggi@...ium.com>
> Acked-by: David Daney <david.daney@...ium.com>

Fixes: b404bcfbf035 ("PCI: Add ACS quirk for all Cavium devices")
Reported-by: Alex Williamson <alex.williamson@...hat.com>
Acked-by: Alex Williamson <alex.williamson@...hat.com>

Thanks

> ---
>   drivers/pci/quirks.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index f754453..178242d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -4094,6 +4094,9 @@ static int pci_quirk_cavium_acs(struct pci_dev *dev, u16 acs_flags)
>   	acs_flags &= ~(PCI_ACS_SV | PCI_ACS_TB | PCI_ACS_RR |
>   		       PCI_ACS_CR | PCI_ACS_UF | PCI_ACS_DT);
>   
> +	if (!((dev->device >= 0xa000) && (dev->device <= 0xa0ff)))
> +		return -ENOTTY;
> +
>   	return acs_flags ? 0 : 1;
>   }
>