linux-kernel - Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170318081455.9bb3126b594ae54da3abe5b2@kernel.org>
Date:   Sat, 18 Mar 2017 08:14:55 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Cc:     mingo@...hat.com, acme@...nel.org, brendan.d.gregg@...il.com,
        peterz@...radead.org, alexander.shishkin@...ux.intel.com,
        wangnan0@...wei.com, jolsa@...nel.org, ak@...ux.intel.com,
        treeze.taeung@...il.com, mathieu.poirier@...aro.org,
        hekuang@...wei.com, sukadev@...ux.vnet.ibm.com, ananth@...ibm.com,
        naveen.n.rao@...ux.vnet.ibm.com, adrian.hunter@...el.com,
        linux-kernel@...r.kernel.org, hemant@...ux.vnet.ibm.com
Subject: Re: [PATCH v5 7/7] perf/sdt: List events fetched from uprobe_events


The title of this patch seems not correct.

On Tue, 14 Mar 2017 20:36:58 +0530
Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> wrote:

> Perf was showing warning if user tries to record sdt event without
> creating a probepoint. Now we are allowing direct record on sdt
> events, remove this stale warning/hint.
> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
> ---
>  tools/lib/api/fs/tracing_path.c | 17 ++++-------------
>  1 file changed, 4 insertions(+), 13 deletions(-)
> 
> diff --git a/tools/lib/api/fs/tracing_path.c b/tools/lib/api/fs/tracing_path.c
> index 3e606b9..fa52e67 100644
> --- a/tools/lib/api/fs/tracing_path.c
> +++ b/tools/lib/api/fs/tracing_path.c
> @@ -103,19 +103,10 @@ int tracing_path__strerror_open_tp(int err, char *buf, size_t size,
>  		 * - jirka
>  		 */
>  		if (debugfs__configured() || tracefs__configured()) {
> -			/* sdt markers */
> -			if (!strncmp(filename, "sdt_", 4)) {
> -				snprintf(buf, size,
> -					"Error:\tFile %s/%s not found.\n"
> -					"Hint:\tSDT event cannot be directly recorded on.\n"
> -					"\tPlease first use 'perf probe %s:%s' before recording it.\n",
> -					tracing_events_path, filename, sys, name);
> -			} else {
> -				snprintf(buf, size,
> -					 "Error:\tFile %s/%s not found.\n"
> -					 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> -					 tracing_events_path, filename);
> -			}
> +			snprintf(buf, size,
> +				 "Error:\tFile %s/%s not found.\n"
> +				 "Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
> +				 tracing_events_path, filename);
>  			break;
>  		}
>  		snprintf(buf, size, "%s",
> -- 
> 2.9.3
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>