linux-kernel - Re: [PATCH] drm: vc4: remove redundant check of plane being non-null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877f3njwbf.fsf@eliezer.anholt.net>
Date:   Fri, 17 Mar 2017 16:52:04 -0700
From:   Eric Anholt <eric@...olt.net>
To:     Colin King <colin.king@...onical.com>,
        David Airlie <airlied@...ux.ie>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: vc4: remove redundant check of plane being non-null

Colin King <colin.king@...onical.com> writes:

> From: Colin Ian King <colin.king@...onical.com>
>
> The pointer plane is always null on the error path at label 'fail'
> hence the check if it is non-null is redundant. We can therefore
> remove the check and the destruction of plane as well as the fail
> error path and instead just return an -ENOMEM ERR_PTR.
>
> Detected by CoverityScan, CID#1339532 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed and applied.  Thanks!

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)