linux-kernel - Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170318092748.sjbagvbzzucycggl@pd.tnic>
Date:   Sat, 18 Mar 2017 10:27:48 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Colin King <colin.king@...onical.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/microcode/AMD: remove redundant null check on mc

On Wed, Mar 15, 2017 at 05:10:10PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> mc is a pointer to the static u8 array amd_ucode_patch and
> therefore can never be null, so the check is redundant. Remove it.
> 
> Detected by CoverityScan, CID#1372871 ("Logically Dead Code")
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  arch/x86/kernel/cpu/microcode/amd.c | 3 ---
>  1 file changed, 3 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.