linux-kernel - Re: [PATCH v2 03/17] iio: magnetometer: bmc150_magn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1f0555f-d89e-3c81-0a03-09b98f388804@kernel.org>
Date:   Sun, 19 Mar 2017 10:50:19 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        linux-kernel@...r.kernel.org
Cc:     Irina Tirdea <irina.tirdea@...el.com>, linux-iio@...r.kernel.org,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Daniel Baluta <daniel.baluta@...el.com>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [PATCH v2 03/17] iio: magnetometer: bmc150_magn_i2c: Add OF
 device ID table

On 15/03/17 04:44, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
> 
> But this could change in the future so the correct approach is to have an
> OF device ID table if the devices are registered via OF.
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
Applied.
> ---
> 
>  drivers/iio/magnetometer/bmc150_magn_i2c.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/iio/magnetometer/bmc150_magn_i2c.c b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> index ee05722587aa..57e40dd1222e 100644
> --- a/drivers/iio/magnetometer/bmc150_magn_i2c.c
> +++ b/drivers/iio/magnetometer/bmc150_magn_i2c.c
> @@ -63,9 +63,18 @@ static const struct i2c_device_id bmc150_magn_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);
>  
> +static const struct of_device_id bmc150_magn_of_match[] = {
> +	{ .compatible = "bosch,bmc150_magn" },
> +	{ .compatible = "bosch,bmc156_magn" },
> +	{ .compatible = "bosch,bmm150_magn" },
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
> +
>  static struct i2c_driver bmc150_magn_driver = {
>  	.driver = {
>  		.name	= "bmc150_magn_i2c",
> +		.of_match_table = bmc150_magn_of_match,
>  		.acpi_match_table = ACPI_PTR(bmc150_magn_acpi_match),
>  		.pm	= &bmc150_magn_pm_ops,
>  	},
>