lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Mar 2017 10:53:17 +0000 From: Jonathan Cameron <jic23@...nel.org> To: Javier Martinez Canillas <javier@....samsung.com>, linux-kernel@...r.kernel.org Cc: linux-iio@...r.kernel.org, Hartmut Knaack <knaack.h@....de>, Gregor Boirie <gregor.boirie@...rot.com>, Sanchayan Maity <maitysanchayan@...il.com>, Lars-Peter Clausen <lars@...afoo.de>, Amitoj Kaur Chawla <amitoj1606@...il.com>, Peter Meerwald-Stadler <pmeerw@...erw.net> Subject: Re: [PATCH v2 06/17] iio: light: tsl2563: Add OF device ID table On 15/03/17 04:44, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:<device>. > > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. > > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com> Applied > --- > > drivers/iio/light/tsl2563.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c > index 04598ae993d4..e7d4ea75e007 100644 > --- a/drivers/iio/light/tsl2563.c > +++ b/drivers/iio/light/tsl2563.c > @@ -884,9 +884,19 @@ static const struct i2c_device_id tsl2563_id[] = { > }; > MODULE_DEVICE_TABLE(i2c, tsl2563_id); > > +static const struct of_device_id tsl2563_of_match[] = { > + { .compatible = "amstaos,tsl2560" }, > + { .compatible = "amstaos,tsl2561" }, > + { .compatible = "amstaos,tsl2562" }, > + { .compatible = "amstaos,tsl2563" }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, tsl2563_of_match); > + > static struct i2c_driver tsl2563_i2c_driver = { > .driver = { > .name = "tsl2563", > + .of_match_table = tsl2563_of_match, > .pm = TSL2563_PM_OPS, > }, > .probe = tsl2563_probe, >
Powered by blists - more mailing lists