linux-kernel - Re: [RESEND PATCH 3/7] Change k_clock clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1703191159550.3781@nanos>
Date:   Sun, 19 Mar 2017 12:03:54 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Deepa Dinamani <deepa.kernel@...il.com>
cc:     linux-kernel@...r.kernel.org, john.stultz@...aro.org,
        arnd@...db.de, y2038@...ts.linaro.org
Subject: Re: [RESEND PATCH 3/7] Change k_clock clock_get() to use
 timespec64

On Sat, 18 Mar 2017, Deepa Dinamani wrote:
> -	int (*clock_get) (const clockid_t which_clock, struct timespec * tp);
> +	int (*clock_get) (const clockid_t which_clock, struct timespec64 * tp);

If you change things, then please fixup the white space noise as well '*tp'
is the proper syntax.

> @@ -1033,12 +1033,14 @@ SYSCALL_DEFINE2(clock_gettime, const clockid_t, which_clock,
>  {
>  	struct k_clock *kc = clockid_to_kclock(which_clock);
>  	struct timespec kernel_tp;
> +	struct timespec64 kernel_tp64;

Ordering please

Other than the nitpicks, this looks good.