linux-kernel - Re: [PATCH 1/5] dt-bindings: Document the STM32 DMAMUX bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170320213413.4b6uopuilznyr2rl@rob-hp-laptop>
Date:   Mon, 20 Mar 2017 16:34:13 -0500
From:   Rob Herring <robh@...nel.org>
To:     M'boumba Cedric Madianga <cedric.madianga@...il.com>
Cc:     vinod.koul@...el.com, mark.rutland@....com,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        dan.j.williams@...el.com, dmaengine@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: Document the STM32 DMAMUX bindings

On Mon, Mar 13, 2017 at 03:15:57PM +0100, M'boumba Cedric Madianga wrote:
> This patch adds the documentation of device tree bindings for the STM32
> DMAMUX.
> 
> Signed-off-by: M'boumba Cedric Madianga <cedric.madianga@...il.com>
> ---
>  .../devicetree/bindings/dma/stm32-dmamux.txt       | 57 ++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> 
> diff --git a/Documentation/devicetree/bindings/dma/stm32-dmamux.txt b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> new file mode 100644
> index 0000000..1039420
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/stm32-dmamux.txt
> @@ -0,0 +1,57 @@
> +STM32 DMA MUX (DMA request router)
> +
> +Required properties:
> +- compatible:	"st,stm32-dmamux"
> +- reg:		Memory map for accessing module
> +- #dma-cells:	Should be set to <4>.
> +		For more details about the four cells, please see stm32-dma.txt
> +		documentation binding file
> +- dma-masters:	Phandle pointing to the DMA controller
> +- clocks: Input clock of the DMAMUX instance.
> +
> +Optional properties:
> +- dma-channels : Number of DMA channels supported.
> +- dma-requests : Number of DMA requests supported.
> +- resets: Reference to a reset controller asserting the DMA controller
> +
> +Example:
> +
> +/* DMA controller */
> +dma2: dma-controller@...26400 {
> +	compatible = "st,stm32-dma";
> +	reg = <0x40026400 0x400>;
> +	interrupts = <56>,
> +		     <57>,
> +		     <58>,
> +		     <59>,
> +		     <60>,
> +		     <68>,
> +		     <69>,
> +		     <70>;
> +	clocks = <&clk_hclk>;
> +	#dma-cells = <4>;
> +	st,mem2mem;
> +	resets = <&rcc 150>;
> +	st,dmamux;
> +	dma-channels = <8>;
> +};
> +
> +/* DMA mux */
> +dmamux2: dma-router@...20820 {
> +	compatible = "st,stm32-dmamux";
> +	reg = <0x40020800 0x1c>;
> +	#dma-cells = <4>;
> +	dma-requests = <128>;
> +	dma-masters = <&dma2>;

I think this should be modeled after the interrupt-map property (or 
Stephen Boyd's gpio-map support which additionally allows pass thru of 
cell values). Something like this:

dma-map = <0 41 0 0 &dma2 0 <req> 0 0>,
	<1 42 0 0 &dma2 1 <req> 0 0>;
dma-map-mask = <0xffffffff 0xffffffff 0 0>;

<req> is the request number on dma2 controller.

This is more generic and would work if you have a single mux with 
multiple DMA controllers.

> +};
> +
> +/* DMA client */
> +usart1: serial@...11000 {
> +	compatible = "st,stm32-usart", "st,stm32-uart";
> +	reg = <0x40011000 0x400>;
> +	interrupts = <37>;
> +	clocks = <&clk_pclk2>;
> +	dmas = <&dmamux2 0 41 0x400 0x00>,
> +	       <&dmamux2 1 42 0x400 0x00>;
> +	dma-names = "rx", "tx";
> +};
> -- 
> 1.9.1
>