linux-kernel - RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 08:47:44 +0000
From:   Piotr Sroka <piotrs@...ence.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
CC:     linux-mmc <linux-mmc@...r.kernel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: RE: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration



> -----Original Message-----
> From: Masahiro Yamada [mailto:yamada.masahiro@...ionext.com]
> Sent: 17 March, 2017 6:24 PM
> Subject: Re: [v3 3/3] mmc: sdhci-cadence: Update PHY delay configuration
> 
> 
> 
> > @@ -62,10 +66,33 @@
> >   */
> >  #define SDHCI_CDNS_MAX_TUNING_LOOP     40
> >
> > +static const struct of_device_id sdhci_cdns_match[];
> > +
> 
> You forgot to remove this.
> 
You are right. Thanks.
 
> 
> > @@ -227,6 +267,7 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
> >         struct sdhci_cdns_priv *priv;
> >         struct clk *clk;
> >         int ret;
> > +       struct device *dev = &pdev->dev;
> >
> >         clk = devm_clk_get(&pdev->dev, NULL);
> 
> 
> If you add "dev", please use it for devm_clk_get, too.
> 
I did on the first patch version but Ulf pointed that this is unrelated change and should be removed. 
Therefore I remove it. 

> 
> 
> --
> Best Regards
> Masahiro Yamada