linux-kernel - Re: [PATCH] scsi: libsas: fix ata xfer length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f5d6b941-f981-b05f-6266-9364878e135f@huawei.com>
Date:   Mon, 20 Mar 2017 08:59:40 +0000
From:   John Garry <john.garry@...wei.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <jejb@...ux.vnet.ibm.com>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH] scsi: libsas: fix ata xfer length

On 19/03/2017 17:21, Martin K. Petersen wrote:
> John Garry <john.garry@...wei.com> writes:
>
> John,
>
>> The total ata xfer length may not be calculated properly,
>> in that we do not use the proper method to get an sg element
>> dma length.
>>
>> According to the code comment, sg_dma_len() should be used
>> after dma_map_sg() is called.
>>
>> This issue was found by turning on the SMMUv3 in front of
>> the hisi_sas controller in hip07. Multiple sg elements
>> were being combined into a single element, but the original
>> first element length was being use as the total xfer length.
>

I should have added this originally to the changelog:
Fixes: ff2aeb1eb64c8a4770a6 ("libata: convert to chained sg")

BTW, I am surprised this issue has not been seen in almost 10 years, but 
we cannot attach a SATA disk when SMMU enabled without it.

Cheers,
John

> Applied to 4.11/scsi-fixes.
>