linux-kernel - [PATCHv2 2/2] super1: check and output faulty dev role

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1490003517-4216-3-git-send-email-gi-oh.kim@profitbricks.com>
Date:   Mon, 20 Mar 2017 10:51:57 +0100
From:   Gioh Kim <gi-oh.kim@...fitbricks.com>
To:     jes.sorensen@...il.com
Cc:     neilb@...e.com, linux-raid@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Jack Wang <jinpu.wang@...fitbricks.com>
Subject: [PATCHv2 2/2] super1: check and output faulty dev role

From: Jack Wang <jinpu.wang@...fitbricks.com>

Output the real dev role in examine_super1, it will help to
find problem.

Signed-off-by: Jack Wang <jinpu.wang@...fitbricks.com>
Reviewed-by: Gioh Kim <gi-oh.kim@...fitbricks.com>
---
 super1.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/super1.c b/super1.c
index f3520ac..c903371 100644
--- a/super1.c
+++ b/super1.c
@@ -501,8 +501,10 @@ static void examine_super1(struct supertype *st, char *homehost)
 #endif
 	printf("   Device Role : ");
 	role = role_from_sb(sb);
-	if (role >= MD_DISK_ROLE_FAULTY)
-		printf("spare\n");
+	if (role == MD_DISK_ROLE_SPARE)
+		printf("Spare\n");
+	else if (role == MD_DISK_ROLE_FAULTY)
+		printf("Faulty\n");
 	else if (role == MD_DISK_ROLE_JOURNAL)
 		printf("Journal\n");
 	else if (sb->feature_map & __cpu_to_le32(MD_FEATURE_REPLACEMENT))
-- 
2.5.0