linux-kernel - Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h4lyow4b3.wl-tiwai@suse.de>
Date:   Mon, 20 Mar 2017 12:55:28 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Matthias Kaehlcke" <mka@...omium.org>
Cc:     "Julia Lawall" <Julia.Lawall@...6.fr>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Sven Hahne" <hahne@...tkunst.eu>, <alsa-devel@...a-project.org>,
        "Grant Grundler" <grundler@...omium.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132: Remove double parentheses

On Wed, 15 Mar 2017 23:41:23 +0100,
Matthias Kaehlcke wrote:
> 
> The extra pairs of parantheses are not needed and causes clang to
> generate warnings like this:
> 
> sound/pci/hda/patch_ca0132.c:1171:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
>         if ((buffer == NULL))
>              ~~~~~~~^~~~~~~
> sound/pci/hda/patch_ca0132.c:1171:14: note: remove extraneous parentheses around the comparison to silence this warning
>         if ((buffer == NULL))
>             ~       ^      ~
> sound/pci/hda/patch_ca0132.c:1171:14: note: use '=' to turn this equality comparison into an assignment
>         if ((buffer == NULL))
> 
> Signed-off-by: Matthias Kaehlcke <mka@...omium.org>

Applied, thanks.


Takashi