linux-kernel - Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 13:55:50 +0200
From:   Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>
To:     Nickey Yang <nickey.yang@...k-chips.com>, <architt@...eaurora.org>,
        <airlied@...ux.ie>
CC:     <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <linux-rockchip@...ts.infradead.org>, <dianders@...omium.org>,
        <laurent.pinchart+renesas@...asonboard.com>,
        <joabreu@...opsys.com>, <andy.yan@...k-chips.com>,
        <zhengyang@...k-chips.com>, <rmk+kernel@....linux.org.uk>
Subject: Re: [PATCH v2] drm/bridge: dw_hdmi: support i2c extended read mode

Hi Nickey,

On 03/20/2017 04:57 AM, Nickey Yang wrote:
> "I2C Master Interface Extended Read Mode" implements a segment
> pointer-based read operation using the Special Register configuration.
> 
> This patch fix https://patchwork.kernel.org/patch/7098101/ mentioned
> "The current implementation does not support "I2C Master Interface
> Extended Read Mode" to read data addressed by non-zero segment
> pointer, this means that if EDID has more than 1 extension blocks"

... EDID reading operation won't succeed.

Indeed.

> 
> With this patch,dw-hdmi can read EDID data with 1/2/4 blocks.
> 
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> ---

Unfortunately I don't have a chance to test the change thoroughly, but
from what I see the implementation is correct. Thank you for the change.

Please feel free to update the commit message and add my

Acked-by: Vladimir Zapolskiy <vladimir_zapolskiy@...tor.com>

--
With best wishes,
Vladimir