linux-kernel - Re: [PATCH 1/4] spi: pl022: remove nonexistent properties from DT binding example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170320134217.GB31213@leverpostej>
Date:   Mon, 20 Mar 2017 13:42:17 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Antonio Borneo <borneo.antonio@...il.com>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Viresh Kumar <vireshk@...nel.org>,
        Shiraz Hashim <shiraz.linux.kernel@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Brijesh Singh <brijeshkumar.singh@....com>,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>, Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Jon Mason <jonmason@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] spi: pl022: remove nonexistent properties from DT
 binding example

On Mon, Mar 20, 2017 at 10:57:18AM +0100, Antonio Borneo wrote:
> The properties "pl022,hierarchy" and "pl022,slave-tx-disable" were
> initially proposed till patch V4 [1] but then discarded in V5 [2]
> when the patch set was taken over by another developer, as
> explained in patch history in [3].
> The above properties never landed in mainline code but were then
> listed in the binding example by a following commit dc715452e914
> ("spi: pl022: use generic DMA slave configuration if possible")
> and later on they were copy-paste in some board's DT.
> 
> Remove the nonexistent properties from the example.
> Also remove a spaces-only line at the end of the file.
> 
> [1] https://lkml.org/lkml/2012/7/9/421
> [2] https://lkml.org/lkml/2012/8/21/427
> [3] https://lkml.org/lkml/2012/8/21/436
> 
> Signed-off-by: Antonio Borneo <borneo.antonio@...il.com>

For the series:

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> diff --git a/Documentation/devicetree/bindings/spi/spi_pl022.txt b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> index 4d1673ca8cf8..2692a5726c3f 100644
> --- a/Documentation/devicetree/bindings/spi/spi_pl022.txt
> +++ b/Documentation/devicetree/bindings/spi/spi_pl022.txt
> @@ -56,9 +56,7 @@ Example:
>  			spi-max-frequency = <12000000>;
>  			spi-cpol;
>  			spi-cpha;
> -			pl022,hierarchy = <0>;
>  			pl022,interface = <0>;
> -			pl022,slave-tx-disable;
>  			pl022,com-mode = <0x2>;
>  			pl022,rx-level-trig = <0>;
>  			pl022,tx-level-trig = <0>;
> @@ -67,4 +65,3 @@ Example:
>  			pl022,duplex = <0>;
>  		};
>  	};
> -	
> -- 
> 2.12.0
>