linux-kernel - Re: [PATCH] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Mar 2017 15:05:03 +0100
From:   Thierry Reding <thierry.reding@...il.com>
To:     Jon Hunter <jonathanh@...dia.com>
Cc:     Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: tegra-bpmp: Enable Tegra BPMP I2C adapter

On Wed, Mar 15, 2017 at 12:20:10PM +0000, Jon Hunter wrote:
> Enable the Tegra BPMP I2C adapter by default if the Tegra BPMP itself
> is enabled. This adapter is used as the I2C interface for the PMIC on
> the Tegra186 Jetson-TX2 platform.
> 
> Signed-off-by: Jon Hunter <jonathanh@...dia.com>
> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 8adc0f1d7ad0..9e024ae8a067 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -933,6 +933,7 @@ config I2C_TEGRA
>  config I2C_TEGRA_BPMP
>  	tristate "NVIDIA Tegra BPMP I2C controller"
>  	depends on TEGRA_BPMP
> +	default y if TEGRA_BPMP

I think "if TEGRA_BPMP" in the line above implies "depends on
TEGRA_BPMP", so it's redundant. "default y" should be equivalent. That
said, I'm not sure if we really want to always enable this. There could
be boards with a BPMP that don't use the I2C controller.

But that's fairly unlikely, so with the redundant dependency on
TEGRA_BPMP fixed, this is:

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)