linux-kernel - Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on pointer 'service'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6549e96-1313-6eba-acbc-cbfc235ac433@i2se.com>
Date:   Mon, 20 Mar 2017 15:26:33 +0100
From:   Stefan Wahren <stefan.wahren@...e.com>
To:     Colin King <colin.king@...onical.com>, Lee Jones <lee@...nel.org>,
        Eric Anholt <eric@...olt.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Zoran <mzoran@...wfest.net>,
        Narcisa Ana Maria Vasile <narcisaanamaria12@...il.com>,
        Phil Elwell <phil@...pberrypi.org>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH] staging: vc04_services: fix NULL pointer dereference on
 pointer 'service'

[add Mauro to CC]

Am 20.03.2017 um 15:08 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
>
> Currently, if pservice is null then service is set to NULL and immediately
> afterwards service is dereferenced causing a null pointer dereference. Fix
> this by bailing out early of the function with a null return.
>
> Detected by CoverityScan, CID#1419681 ("Explicit null dereferenced")
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Stefan Wahren <stefan.wahren@...e.com>