linux-kernel - Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a0YvHwooiAg_6PQ4e879=rwM9wJzLFQLg_21JfK4jUGSA@mail.gmail.com>
Date:   Mon, 20 Mar 2017 17:29:54 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alan Cox <alan@...ux.intel.com>, linux-media@...r.kernel.org
Subject: Re: [PATCH 3/9] stating/atomisp: fix -Wold-style-definition warning

On Mon, Mar 20, 2017 at 4:05 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Mon, 20 Mar 2017 10:32:19 +0100
> Arnd Bergmann <arnd@...db.de> wrote:
>
>> -void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/)
>> +void ia_css_dequeue_param_buffers(/*unsigned int pipe_num*/ void)
>>  {
> Why keep the comment?

The comment matches one later in the file when this function gets called.

I thought about cleaning up both at the same time, but couldn't figure out
how the comment ended up in there or why it was left behind in the first
place, so I ended up leaving both for another patch on top. If you prefer,
I could resend the patch and do both at once.

        Arnd