linux-kernel - Re: mwifiex: pcie: clean up error prints in mwifiex_pcie_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20170320170456.83A596084C@smtp.codeaurora.org>
Date:   Mon, 20 Mar 2017 17:04:56 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Amitkumar Karwar <akarwar@...vell.com>,
        Nishant Sarmukadam <nishants@...vell.com>,
        <linux-kernel@...r.kernel.org>, linux-wireless@...r.kernel.org,
        Brian Norris <briannorris@...omium.org>
Subject: Re: mwifiex: pcie: clean up error prints in
 mwifiex_pcie_reset_notify()

Brian Norris <briannorris@...omium.org> wrote:
> We shouldn't be printing a kernel pointer as a decimal integer. But we
> really shouldn't be printing this case at all; we should never get here
> with NULL drvdata. We've eliminated this unnecessary conditional in
> several other places, so kill it here too.
> 
> Similarly, there's no need to check for '!pdev'; we are guaranteed to
> have a real device here.
> 
> And finally, use dev_err() instead of pr_err().
> 
> This yields (for failed PCIe resets):
> 
> [   68.286586] mwifiex_pcie 0000:01:00.0: mwifiex_pcie_reset_notify: adapter structure is not valid
> 
> instead of:
> 
> [   82.932658] mwifiex_pcie: mwifiex_pcie_reset_notify: Card or adapter structure is not valid (-270880688088)
> 
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Patch applied to wireless-drivers-next.git, thanks.

520334156213 mwifiex: pcie: clean up error prints in mwifiex_pcie_reset_notify()

-- 
https://patchwork.kernel.org/patch/9609861/

Documentation about submitting wireless patches and checking status
from patchwork:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches