lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Mar 2017 18:44:42 +0100 From: Niklas Cassel <niklas.cassel@...s.com> To: Joao Pinto <Joao.Pinto@...opsys.com> CC: <peppe.cavallaro@...com>, <alexandre.torgue@...com>, <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe On 03/20/2017 06:42 PM, Joao Pinto wrote: > Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >> From: Niklas Cassel <niklas.cassel@...s.com> >> >> It is usually possible to do >> ethtool -s autoneg on >> so that you trigger an autoneg before calling >> ip link set dev eth0 up >> >> However, stmmac returns -EBUSY if !netif_running. >> The only reason for this appears to be that stmmac_init_phy >> is called from stmmac_open instead of from stmmac_dvr_probe. >> >> Move stmmac_init_phy to stmmac_dvr_probe so that ethool >> works as soon as register_netdev has been called. >> stmmac_check_ether_addr was also moved to probe, >> so that the ordering doesn't change. >> >> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com> >> --- > Hi Niklas, did you test this patch? I tested it on our hardware, but it would be nice if you could test it on your side, since you are using the PCI glue layer.
Powered by blists - more mailing lists