linux-kernel - Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPDyKFr-08ontZTfraOEAOROcb9pqFQkqzV4zMRA4OdsxXrvtQ@mail.gmail.com>
Date:   Mon, 20 Mar 2017 19:10:56 +0100
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Philipp Zabel <p.zabel@...gutronix.de>
Cc:     Andrzej Hajda <a.hajda@...sung.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Szyprowski, Marek" <m.szyprowski@...sung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-samsung-soc <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 06/14] mmc: dw_mmc: simplify optional reset handling

On 20 March 2017 at 12:00, Philipp Zabel <p.zabel@...gutronix.de> wrote:
> On Mon, 2017-03-20 at 11:49 +0100, Andrzej Hajda wrote:
>> On 20.03.2017 11:27, Philipp Zabel wrote:
> [...]
>> > diff --git a/include/linux/reset.h b/include/linux/reset.h
>> > index 86b4ed75359e8..c905ff1c21ec6 100644
>> > --- a/include/linux/reset.h
>> > +++ b/include/linux/reset.h
>> > @@ -74,14 +74,14 @@ static inline struct reset_control *__of_reset_control_get(
>> >                                     const char *id, int index, bool shared,
>> >                                     bool optional)
>> >  {
>> > -   return ERR_PTR(-ENOTSUPP);
>> > +   return optional ? NULL : ERR_PTR(-ENOTSUPP);
>> >  }
>> >
>> >  static inline struct reset_control *__devm_reset_control_get(
>> >                                     struct device *dev, const char *id,
>> >                                     int index, bool shared, bool optional)
>> >  {
>> > -   return ERR_PTR(-ENOTSUPP);
>> > +   return optional ? NULL : ERR_PTR(-ENOTSUPP);
>> >  }
>> >
>> >  #endif /* CONFIG_RESET_CONTROLLER */
>> > ---------->8----------
>>
>> In dw_mmc.c file there are also unconditional calls to
>> reset_control_assert, with disabled RESET_CONTROLLER it will cause
>> unexpected WARNs.
>> Anyway if you change reset API as above I think you should remove all
>> warns from reset stubs, because NULL reset is valid, but these warns are
>> there for reason - contradiction.
>
> You are right, I have to let go of those, too.


Until fixed, I have dropped the three changes from my next branch
related to this. Please re-post when fixed.

Kind regards
Uffe

>
> regards
> Philipp
>