linux-kernel - Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7d0425c1-de9a-cb1a-fde7-71e903579562@nvidia.com>
Date:   Tue, 21 Mar 2017 10:37:29 +0000
From:   Jon Hunter <jonathanh@...dia.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Stephen Warren <swarren@...dotorg.org>,
        Thierry Reding <thierry.reding@...il.com>,
        "Alexandre Courbot" <gnurou@...il.com>
CC:     <linaro-kernel@...ts.linaro.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc/tegra: pmc: Don't allocate struct tegra_powergate on
 stack


On 21/03/17 05:24, Viresh Kumar wrote:
> The size of the struct tegra_powergate is quite big and if any more
> fields are added to the internal genpd structure, following warnings are
> thrown:
> 
> drivers/soc/tegra/pmc.c:577:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=]

Hmmm ... AFAICT the size of the tegra_powergate struct is 312 bytes
(based upon next-20170321) and so it looks like something massive needs
to be added to the genpd struct to blow this up to over 1024 bytes. Are
there some genpd changes in-flight that are causing this?

Cheers
Jon

-- 
nvpublic