linux-kernel - Re: [PATCH 2/2] regulator: hi655x: Bump parent pmic module use count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170321110804.qlyqqiuunrpuklqu@sirena.org.uk>
Date:   Tue, 21 Mar 2017 11:08:04 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Jeremy Linton <lintonrjeremy@...il.com>
Cc:     linux-kernel@...r.kernel.org, lgirdwood@...il.com,
        puck.chen@...ilicon.com, lee.jones@...aro.org
Subject: Re: [PATCH 2/2] regulator: hi655x: Bump parent pmic module use count

On Mon, Mar 20, 2017 at 11:53:41PM -0500, Jeremy Linton wrote:

> +	if (!try_module_get(parent->driver->owner)) {
> +		dev_err(&pdev->dev, "unable to get parent module\n");
> +		return -ENODEV;
> +	}
> +

If this makes sense it should be being done in the driver core, not open
coded in individual drivers.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)