linux-kernel - Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170321141222.GE22188@leverpostej>
Date:   Tue, 21 Mar 2017 14:12:22 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     Anurup M <anurupvasu@...il.com>
Cc:     corbet@....net, will.deacon@....com, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        anurup.m@...wei.com, zhangshaokun@...ilicon.com,
        tanxiaojun@...wei.com, xuwei5@...ilicon.com,
        sanil.kumar@...ilicon.com, john.garry@...wei.com,
        gabriele.paoloni@...wei.com, shiju.jose@...wei.com,
        huangdaode@...ilicon.com, linuxarm@...wei.com,
        dikshit.n@...wei.com, shyju.pv@...wei.com
Subject: Re: [PATCH v6 04/11] Documentation: perf: hisi: Documentation for
 HiP05/06/07 PMU event counting.

Hi,

On Fri, Mar 10, 2017 at 01:27:39AM -0500, Anurup M wrote:

> +HiP0x chips are encapsulated by multiple CPU and IO die's. The CPU die is

Nit: that apostrophe shouldn't be there.

[...]

> +The current driver doesnot support sampling. so "perf record" is unsupported.

Nit: spacing

Otherwise, this looked fine.

Thanks,
Mark.