linux-kernel - Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that '-'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170321141758.2tkatnqyphdpw7rm@darkstar>
Date:   Tue, 21 Mar 2017 07:17:58 -0700
From:   Matthew Giassa <matthew@...ssa.net>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: vt6656: rf.c: spaces preferred around that
 '-'

* Dan Carpenter <dan.carpenter@...cle.com> [2017-03-21 15:55:52 +0300]:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'
>>
>> Signed-off-by: Matthew Giassa <matthew@...ssa.net>
>> ---
>>  drivers/staging/vt6656/rf.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/vt6656/rf.c b/drivers/staging/vt6656/rf.c
>> index 0e3a62a..fe09627 100644
>> --- a/drivers/staging/vt6656/rf.c
>> +++ b/drivers/staging/vt6656/rf.c
>> @@ -611,7 +611,7 @@ int vnt_rf_write_embedded(struct vnt_private *priv, u32 data)
>>  	reg_data[3] = (u8)(data >> 24);
>>
>>  	vnt_control_out(priv, MESSAGE_TYPE_WRITE_IFRF,
>> -				0, 0, ARRAY_SIZE(reg_data), reg_data);
>> +			0, 0, ARRAY_SIZE(reg_data), reg_data);
>
>This isn't described in the changelog.
>
>regards,
>dan carpenter
>

Would it be preferable if the changelog was more verbose? The
literal text from the checkpatch.pl warning itself is indeed in the
changelog:

>On Mon, Mar 20, 2017 at 08:46:01PM -0700, Matthew Giassa wrote:
>> Resolving 2 checkpatch warnings generated due to:
>> CHECK: spaces preferred around that '-'

Cheers.