linux-kernel - Re: [PATCH 06/11] net: usb: mcs7830: use new api ethtool_{get|set}_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc26076e-7ef5-17f1-33c9-fabcb84dd66d@gmail.com>
Date:   Tue, 21 Mar 2017 15:36:20 +0100
From:   poma <pomidorabelisima@...il.com>
To:     Philippe Reynes <tremyfr@...il.com>, oliver@...kum.org,
        jacmet@...site.dk, steve.glendinning@...well.net,
        UNGLinuxDriver@...rochip.com, gregkh@...uxfoundation.org,
        davem@...emloft.net, robert.foss@...labora.com, allan@...x.com.tw,
        grundler@...gle.com, jarod@...hat.com, peter.chen@....com,
        stefan.bruens@...h-aachen.de, akpm@...ux-foundation.org,
        adobriyan@...il.com
Cc:     linux-usb@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/11] net: usb: mcs7830: use new api
 ethtool_{get|set}_link_ksettings

On 16.03.2017 23:18, Philippe Reynes wrote:
> The ethtool api {get|set}_settings is deprecated.
> We move this driver to new api {get|set}_link_ksettings.
> 
> As I don't have the hardware, I'd be very pleased if
> someone may test this patch.
> 
> Signed-off-by: Philippe Reynes <tremyfr@...il.com>
> ---
>  drivers/net/usb/mcs7830.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/mcs7830.c b/drivers/net/usb/mcs7830.c
> index 4f345bd..5771ff2 100644
> --- a/drivers/net/usb/mcs7830.c
> +++ b/drivers/net/usb/mcs7830.c
> @@ -464,9 +464,9 @@ static void mcs7830_get_regs(struct net_device *net, struct ethtool_regs *regs,
>  	.get_link		= usbnet_get_link,
>  	.get_msglevel		= usbnet_get_msglevel,
>  	.set_msglevel		= usbnet_set_msglevel,
> -	.get_settings		= usbnet_get_settings,
> -	.set_settings		= usbnet_set_settings,
>  	.nway_reset		= usbnet_nway_reset,
> +	.get_link_ksettings	= usbnet_get_link_ksettings,
> +	.set_link_ksettings	= usbnet_set_link_ksettings,
>  };
>  
>  static const struct net_device_ops mcs7830_netdev_ops = {
> 

$ modinfo mcs7830 usbnet mii -n
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/mcs7830.ko
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/usbnet.ko
/lib/modules/4.11.0-0.rc3.git0.1.fc26.x86_64/updates/mii.ko

$ lsmod | grep mcs7830
mcs7830                16384  0
usbnet                 45056  1 mcs7830
mii                    16384  2 usbnet,mcs7830

$ nmcli -f GENERAL.DRIVER,GENERAL.STATE device show enp0s4f1u4
GENERAL.DRIVER:                         MOSCHIP usb-ethernet driver
GENERAL.STATE:                          100 (connected)

Tested-by: poma <poma@...il.com>