linux-kernel - Re: [PATCH] fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Mar 2017 15:07:26 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Olimpiu Dejeu <olimpiu@...ticsand.com>,
        kbuild test robot <lkp@...el.com>, fengguang.wu@...el.com
Cc:     kbuild-all@...org, Rob Herring <robh@...nel.org>,
        Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
        linux-fbdev@...r.kernel.org, devicetree@...r.kernel.org,
        jingoohan1@...il.com, Brian Dodge <bdodge@...ticsand.com>,
        joe@...ches.com, Matthew D'Asaro <medasaro@...ticsand.com>
Subject: Re: [PATCH] fix ptr_ret.cocci warnings

On 21/03/17 14:58, Olimpiu Dejeu wrote:
> On Fri, Mar 17, 2017 at 10:48 AM, kbuild test robot <lkp@...el.com> wrote:
>> drivers/video/backlight/arcxcnn_bl.c:183:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>>
>>
>>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>>
>> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>>
>> CC: Olimpiu Dejeu <olimpiu@...ticsand.com>
>> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
>> ---
>>
>>  arcxcnn_bl.c |    5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> --- a/drivers/video/backlight/arcxcnn_bl.c
>> +++ b/drivers/video/backlight/arcxcnn_bl.c
>> @@ -180,10 +180,7 @@ static int arcxcnn_backlight_register(st
>>
>>         lp->bl = devm_backlight_device_register(lp->dev, name, lp->dev, lp,
>>                                        &arcxcnn_bl_ops, props);
>> -       if (IS_ERR(lp->bl))
>> -               return PTR_ERR(lp->bl);
>> -
>> -       return 0;
>> +       return PTR_ERR_OR_ZERO(lp->bl);
>>  }
>>
>>  static void arcxcnn_parse_dt(struct arcxcnn *lp)
>
> Acked-by: Olimpiu Dejeu <olimpiu@...ticsand.com>

Glad you approve! Could you apply this change and re-post the patch 
series? Thanks.


Daniel.