linux-kernel - Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACSApvbY0a6NFs+k1X5wMJC007z-NgYzgSdpuAncw6PHvNhu5g@mail.gmail.com>
Date:   Tue, 21 Mar 2017 12:25:58 -0400
From:   Soheil Hassas Yeganeh <soheil@...gle.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     Dmitry Vyukov <dvyukov@...gle.com>, kcc@...gle.com,
        Eric Dumazet <edumazet@...gle.com>,
        David Miller <davem@...emloft.net>, kuznet@....inr.ac.ru,
        linux-kernel@...r.kernel.org, netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv6: make sure to initialize sockc.tsflags before first use

On Tue, Mar 21, 2017 at 12:14 PM, Alexander Potapenko <glider@...gle.com> wrote:
> In the case udp_sk(sk)->pending is AF_INET6, udpv6_sendmsg() would
> jump to do_append_data, skipping the initialization of sockc.tsflags.
> Fix the problem by moving sockc.tsflags initialization earlier.
>
> The bug was detected with KMSAN.

Nice catch and thanks for the fix! This is missing a "fixes"
attribution, added below.

> Signed-off-by: Alexander Potapenko <glider@...gle.com>

Fixes: c14ac9451c34 ("sock: enable timestamping using control messages")
Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>