linux-kernel - Re: [PATCH] mailbox: check ->last_tx_done for NULL in case of timer-based polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7b0ee7c4-6470-bfe8-1609-79283c4f4de3@arm.com>
Date:   Tue, 21 Mar 2017 17:03:21 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Alexey Klimov <alexey.klimov@....com>, jassisinghbrar@...il.com,
        linux-kernel@...r.kernel.org
Cc:     Sudeep Holla <sudeep.holla@....com>, jaswinder.singh@...aro.org
Subject: Re: [PATCH] mailbox: check ->last_tx_done for NULL in case of
 timer-based polling



On 21/03/17 16:57, Alexey Klimov wrote:
> It is allowed by code to register mailbox controller that sets txdone_poll
> flag to request timer-based polling with missed ->last_tx_done() method.
> If such thing happens and since presence of last_tx_done() is not checked
> it will fail in hrtimer callback function txdone_hrtimer() when first
> message will be transmitted.
> 
> This patch adds check for this method and logging of error on
> registration of mailbox controller if it requested timer-based polling.
> 

Good to have check.

Acked-by: Sudeep Holla <sudeep.holla@....com>

-- 
Regards,
Sudeep