linux-kernel - Re: [PING PATCH v2] jump label: fix passing kbuild_cflags when checking for asm goto support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNATDkCkC=XqA8xkECNhKf_Jh+4aWLgaNZGopBdrVAxHPhg@mail.gmail.com>
Date:   Wed, 22 Mar 2017 02:48:44 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        David Lin <dtwlin@...gle.com>,
        "Anton V. Boyarshinov" <boyarsh@...linux.org>,
        "Dmitry V. Levin" <ldv@...linux.org>,
        Michal Marek <mmarek@...e.com>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PING PATCH v2] jump label: fix passing kbuild_cflags when
 checking for asm goto support

2017-03-21 2:15 GMT+09:00 Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>:
> The latest change of asm goto support check added passing of KBUILD_CFLAGS
> to compiler.  When these flags reference gcc plugins that are not built yet,
> the check fails.
>
> When one runs "make bzImage" followed by "make modules", the kernel is always
> built with HAVE_JUMP_LABEL disabled, while the modules are built depending on
> CONFIG_JUMP_LABEL.  If HAVE_JUMP_LABEL macro happens to be different, modules
> are built with undefined references, e.g.:
>
> ERROR: "static_key_slow_inc" [net/netfilter/xt_TEE.ko] undefined!
> ERROR: "static_key_slow_dec" [net/netfilter/xt_TEE.ko] undefined!
> ERROR: "static_key_slow_dec" [net/netfilter/nft_meta.ko] undefined!
> ERROR: "static_key_slow_inc" [net/netfilter/nft_meta.ko] undefined!
> ERROR: "nf_hooks_needed" [net/netfilter/ipvs/ip_vs.ko] undefined!
> ERROR: "nf_hooks_needed" [net/ipv6/ipv6.ko] undefined!
> ERROR: "static_key_count" [net/ipv6/ipv6.ko] undefined!
> ERROR: "static_key_slow_inc" [net/ipv6/ipv6.ko] undefined!
>
> This change moves the check before all these references are added
> to KBUILD_CFLAGS.  This is correct because subsequent KBUILD_CFLAGS
> modifications are not relevant to this check.
>
> Reported-by: Anton V. Boyarshinov <boyarsh@...linux.org>
> Fixes: 35f860f9ba6a ("jump label: pass kbuild_cflags when checking for asm goto support")
> Cc: stable@...r.kernel.org      # v4.10
> Signed-off-by: Gleb Fotengauer-Malinovskiy <glebfm@...linux.org>
> Signed-off-by: Dmitry V. Levin <ldv@...linux.org>
> Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Acked-by: David Lin <dtwlin@...gle.com>
> ---
> v2: update description of the problem fixed by this patch
>


I assume this PING is addressed to me.

First, Steven asked Andrew to pick up this,
but I have not seen it in linux-next yet. So,

Applied to linux-kbuild/fixes.  Thanks!




-- 
Best Regards
Masahiro Yamada