linux-kernel - Re: [PATCH 1/1] gconfig: remove misleading parentheses around a condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 22 Mar 2017 02:58:27 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Nicolas Iooss <nicolas.iooss_linux@....org>
Cc:     "Yann E. MORIN" <yann.morin.1998@...e.fr>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] gconfig: remove misleading parentheses around a condition

2017-03-14 4:33 GMT+09:00 Nicolas Iooss <nicolas.iooss_linux@....org>:
> When building the kernel with clang, the compiler complains about the
> presence of a condition inside two pairs of parentheses:
>
>     scripts/kconfig/gconf.c:917:19: error: equality comparison with
>     extraneous parentheses [-Werror,-Wparentheses-equality]
>                     } else if ((col == COL_OPTION)) {
>                                 ~~~~^~~~~~~~~~~~~
>     scripts/kconfig/gconf.c:917:19: note: remove extraneous parentheses
>     around the comparison to silence this warning
>                     } else if ((col == COL_OPTION)) {
>                                ~    ^            ~
>     scripts/kconfig/gconf.c:917:19: note: use '=' to turn this equality
>     comparison into an assignment
>                     } else if ((col == COL_OPTION)) {
>                                     ^~
>                                     =
>
> Silence this warning by removing a level of parentheses.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@....org>


Applied to linux-kbuild/fixes.   Thanks!


-- 
Best Regards
Masahiro Yamada