linux-kernel - Re: [PATCH] trace-cmd: Fix segmentation fault in trace-snapshot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170321143543.210ab58a@vmware.local.home>
Date:   Tue, 21 Mar 2017 14:35:43 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     John Kacur <jkacur@...hat.com>
Cc:     lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trace-cmd: Fix segmentation fault in trace-snapshot

On Tue, 21 Mar 2017 17:11:53 +0100
John Kacur <jkacur@...hat.com> wrote:

> To reproduce the problem:
> 
>   plugin 'wakeup'
> trace-cmd: Device or resource busy
>   Segmentation fault (core dumped)
> 
> When the user triggers a condition such as EBUSY the program should
> die gracefully. The problem here is simply caused by an extra
> conversion specifier in "die" in the write_file function

Thanks John!

I'm currently traveling but I'll apply this when I get a chance.

-- Steve

> 
> Signed-off-by: John Kacur <jkacur@...hat.com>
> ---
>  trace-snapshot.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/trace-snapshot.c b/trace-snapshot.c
> index 9d3608c49563..771b065ccfa4 100644
> --- a/trace-snapshot.c
> +++ b/trace-snapshot.c
> @@ -42,7 +42,8 @@ static void write_file(const char *name, char *val)
>  
>  	n = write(fd, val, strlen(val));
>  	if (n < 0)
> -		die("failed to write '%d' to %s\n", path);
> +		die("failed to write to %s\n", path);
> +
>  	tracecmd_put_tracing_file(path);
>  	close(fd);
>  }